🌱 Add periodic jobs for optional tests and release branches #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/L
lentzi90
force-pushed
the
lentzi90/e2e-periodic-optional-gh-workflows
branch
from
098ab62
to
cbcc7a1
Compare
This adds more github workflows, namely periodic jobs for the release branches with the required e2e tests and periodic jobs for the optional e2e tests for main and release branches. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
lentzi90
force-pushed
the
lentzi90/e2e-periodic-optional-gh-workflows
branch
from
cbcc7a1
to
4792e1b
Compare
lentzi90
commented
Jun 4, 2024
| # We need a new shell to pick up the new group. That is why we do the sudo -s -u $USER ... | ||
| # Remove the pre-installed go version. We install the exact version we need. | ||
| run: | | ||
| sudo usermod -a -G libvirt $USER | ||
| sudo rm /usr/bin/go | ||
| sudo -s -u $USER bash ${{ github.workspace }}/hack/ci-e2e.sh | ||
| sudo -s -u $USER --preserve-env bash ${{ github.workspace }}/hack/ci-e2e.sh |
There was a problem hiding this comment.
Note: This was a mistake in the previous PR. The env vars were not passed through. By adding --preserve-env we make sure that the environment variables really are available in the script. The consequence is that we so far only tested redfish-virtualmedia because the BMC_PROTOCOL was never set 🤦
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
kashifest
reviewed
Jun 4, 2024
metal3-io-bot
added
the
do-not-merge/hold
lentzi90
force-pushed
the
lentzi90/e2e-periodic-optional-gh-workflows
branch
from
4792e1b
to
9165d81
Compare
|
Test commit removed. |
|
/hold cancel |
metal3-io-bot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds more github workflows, namely periodic jobs for the release branches with the required e2e tests and periodic jobs for the optional e2e tests for main and release branches.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #