🌱 Make kustomize apply function not dependent on ginkgo

[mquhuy]

The goal is to make this function usable for other packages, which may not use ginkgo

[mquhuy]

/cc @kashifest @tuminoid

I would like to merge this before 0.7 release, so that this function could be used in deploy-cli.

[tuminoid]

/cc @kashifest @tuminoid

I would like to merge this before 0.7 release, so that this function could be used in deploy-cli.

You're suggesting using code from e2e tests in deploy, which is non-test code? If that is what you're after, then this code should live somewhere else.

[kashifest]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tuminoid]

/hold

[mquhuy]

/cc @kashifest @tuminoid
I would like to merge this before 0.7 release, so that this function could be used in deploy-cli.

You're suggesting using code from e2e tests in deploy, which is non-test code? If that is what you're after, then this code should live somewhere else.

Agreed. But currently we don't have anywhere more suitable for this code. I don't think it's a blocker though, we can decide on having common package which can be imported by both test and non-test later.

[tuminoid]

/cc @kashifest @tuminoid
I would like to merge this before 0.7 release, so that this function could be used in deploy-cli.

You're suggesting using code from e2e tests in deploy, which is non-test code? If that is what you're after, then this code should live somewhere else.

Agreed. But currently we don't have anywhere more suitable for this code. I don't think it's a blocker though, we can decide on having common package which can be imported by both test and non-test later.

This change is fine by itself as it just removes Ginkgo calls, but do not use it in deploy-cli without relocating it elsewhere first. We should not be importing test code into prod code.

[tuminoid]

/lgtm
/unhold