Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vendor neutrality policy #19

Merged
merged 1 commit into from
Jul 12, 2024
Merged

add vendor neutrality policy #19

merged 1 commit into from
Jul 12, 2024

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Jul 8, 2024

This commit:

  • adds both a vendor neutrality declaration and explains Metal3-io's vendor neutrality related to hardware, feature and development infrastructure.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2024
@Rozzii Rozzii force-pushed the vendor-neutrality branch 2 times, most recently from e1a7484 to 675c364 Compare July 8, 2024 10:09
@Rozzii
Copy link
Member Author

Rozzii commented Jul 8, 2024

/cc @dtantsur @elfosardo

smoshiur1237
smoshiur1237 reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Left few comments to improve readability.

VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
@Rozzii Rozzii requested a review from smoshiur1237 July 8, 2024 13:58
smoshiur1237
smoshiur1237 reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@smoshiur1237
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
elfosardo
elfosardo suggested changes Jul 8, 2024
View reviewed changes
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
elfosardo
elfosardo reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
there are still a couple of double spaces that I missed before, but it's ok for me as it is
thanks!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
dtantsur
dtantsur reviewed Jul 10, 2024
View reviewed changes
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
dtantsur
dtantsur reviewed Jul 10, 2024
View reviewed changes
VENDOR_NEUTRALITY.md Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
smoshiur1237
smoshiur1237 reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rozzii
add vendor neutrality policy
9c424a5 
This commit:
 - adds both a vendor neutrality declaration and explains Metal3-io's vendor
   neutrality related to hardware, feature and development infrastructure.

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
kashifest
kashifest reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@kashifest
Copy link
Member

Adding the missing lgtm as well since the Small nit fix took it away
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@metal3-io-bot metal3-io-bot merged commit 7d3b486 into metal3-io:main Jul 12, 2024
3 checks passed
@tuminoid tuminoid deleted the vendor-neutrality branch August 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@honza honza Awaiting requested review from honza

@elfosardo elfosardo Awaiting requested review from elfosardo

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rozzii @smoshiur1237 @metal3-io-bot @kashifest @dtantsur @elfosardo