Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove unused variable IRONIC_VMEDIA_SCHEME #534

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

MahnoorAsghar
Copy link
Contributor

@MahnoorAsghar MahnoorAsghar commented Jul 30, 2024

This variable is not used anywhere in ironic-image, ironic and baremetal-operator

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 30, 2024
Signed-off-by: Mahnoor Asghar <masghar@redhat.com>
@MahnoorAsghar MahnoorAsghar changed the title Remove unused variable IRONIC_VMEDIA_SCHEME 🌱 Remove unused variable IRONIC_VMEDIA_SCHEME Jul 30, 2024
@MahnoorAsghar
Copy link
Contributor Author

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
@dtantsur
Copy link
Member

Indeed

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@metal3-io-bot metal3-io-bot merged commit c252b5c into metal3-io:main Jul 30, 2024
8 of 10 checks passed
@MahnoorAsghar MahnoorAsghar deleted the remove-unused-var branch July 30, 2024 13:57
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants