Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fix syntax in build images github workflow #539

Merged
merged 1 commit into from
Aug 20, 2024
Merged

🌱 Fix syntax in build images github workflow #539

merged 1 commit into from
Aug 20, 2024

Conversation

NymanRobin
Copy link
Member

The syntax error in build images workflow caused all jobs to fail. These could probably be automatically caught in the future

@NymanRobin
Fix syntax in build images github workflow
354667e 
The syntax error in build images workflow caused
all jobs to fail.

Signed-off-by: NymanRobin <robin.nyman@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2024
tuminoid
tuminoid reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@NymanRobin
Copy link
Member Author

/cc @dtantsur @elfosardo @zaneb

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@metal3-io-bot metal3-io-bot merged commit ecf51c2 into metal3-io:main Aug 20, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the fix-syntax-in-build-images-workflow branch August 20, 2024 08:03
@tuminoid
Copy link
Member

tuminoid commented Sep 5, 2024

/cherry-pick release-25.0

@tuminoid
Copy link
Member

tuminoid commented Sep 5, 2024

/cherry-pick release-24.1

@tuminoid
Copy link
Member

tuminoid commented Sep 5, 2024

/cherry-pick release-24.0

@metal3-io-bot metal3-io-bot mentioned this pull request Sep 5, 2024
Merged
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #553

In response to this:

/cherry-pick release-25.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Sep 5, 2024
Merged
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #554

In response to this:

/cherry-pick release-24.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #555

In response to this:

/cherry-pick release-24.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Sep 5, 2024
Merged
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Sep 5, 2024
@openshift-merge-bot
Merge pull request metal3-io#539 from openshift-bot/art-consistency-o…
febcb6d 
…penshift-4.18-ironic

OCPBUGS-38275: Updating ironic-container image to be consistent with ART for 4.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NymanRobin @tuminoid @metal3-io-bot @elfosardo