Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GOPROXY to get latest releases instead of git APIs #1376

Open
adilGhaffarDev opened this issue Apr 8, 2024 · 5 comments
Open

Use GOPROXY to get latest releases instead of git APIs #1376

adilGhaffarDev opened this issue Apr 8, 2024 · 5 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@adilGhaffarDev
Copy link
Member

adilGhaffarDev commented Apr 8, 2024

Problem

Here:

function get_latest_release() {

We are using git api to get the latest releases, if git API is used multiple times without GITHUB_TOKEN we start getting following error:

rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable

Solution

Instead of using git APIs we should use GOPROXY. In this way we will not need GITHUB_TOKEN and we will also get rid of rate limit error.

Below are GOPROXY links that list out all releases:

Write a function that get latest release from GOPROXY links and use that to get latest releases

/good-first-issue

@metal3-io-bot
Copy link
Collaborator

@adilGhaffarDev:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Problem

Here:

function get_latest_release() {

We are using git api to get the latest releases, if git API is used multiple times without GITHUB_TOKEN we start getting following error:

rate limit for github api has been reached. Please wait one hour or get a personal API token and assign it to the GITHUB_TOKEN environment variable

Solution:

Instead of using git APIs we should use GOPROXY. In this way we will not need GITHUB_TOKEN and we will also get rid of rate limit error.

Below are GOPROXY links that list out all releases:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 8, 2024
@adilGhaffarDev
Copy link
Member Author

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Apr 8, 2024
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2024
@Rozzii
Copy link
Member

Rozzii commented Jul 10, 2024

/remove-lifecycle stale

1 similar comment
@Rozzii
Copy link
Member

Rozzii commented Jul 10, 2024

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants