🌱 Write bmhs in separated files #1353
Conversation
metal3-io-bot
added
the
size/S
|
/test-centos-integration-release-1-6 |
|
/test-centos-integration-release-1-6 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
LGTM |
03_launch_mgmt_cluster.sh
Outdated
| # Create each bmh and secret in a separated file | ||
| # TODO (mboukhalfa): removed the old make_bm_hosts when this adopted by all tests | ||
| # | ||
| function make_bm_hosts_seprated() { |
There was a problem hiding this comment.
IMO the name make_separated_bm_hosts() might be more suitable. Anw, I think it's better to add a custom param separate=${1:-false}, instead of duplicating the function
There was a problem hiding this comment.
Please check now in once function and saving in separated files and everything in the old file
mboukhalfa
force-pushed
the
Write-bmhs-in-separated-files/mboukhalfa
branch
2 times, most recently
from
98a64ce
to
69877fa
Compare
metal3-io-bot
added
size/XS
|
/test-centos-integration-release-1-6 |
|
lgtm |
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
mboukhalfa
force-pushed
the
Write-bmhs-in-separated-files/mboukhalfa
branch
from
69877fa
to
ad0a4a4
Compare
|
/test-centos-integration-release-1-6 |
|
/lgtm |
This PR add writing bmh files in separated files while keeping the old way of putting everything in one file because all the tests using dev-env expect it we can after merging this adapt them then remove the old function.
We need this changes because when creating multiple clusters in different namespaces each namespace need its own bmh applying everything from one file is not convenient we need to apply only bmh that we need in each namespace