Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ironic-image required tests to Prow tests #696

Merged
merged 1 commit into from
Apr 12, 2024
Merged

update ironic-image required tests to Prow tests #696

merged 1 commit into from
Apr 12, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Apr 12, 2024 •
edited
Loading

Update ironic-image required tests to Prow tests. Remove optional tests as they conflict with required tests, and make little sense to be available cross-releases.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 12, 2024
@tuminoid tuminoid force-pushed the tuomo/update-required-tests-ironic-image branch 2 times, most recently from ca63af6 to 1234b40 Compare April 12, 2024 05:00
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2024
@tuminoid
Copy link
Member Author

/hold

Optional tests needed to be removed as they conflict with required tests. IMO they also make little sense anyways. Thoughts?

/cc @mboukhalfa @kashifest @lentzi90

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
lentzi90
lentzi90 suggested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prow jobs have to stay if we want to trigger the tests through prow.

prow/manifests/overlays/metal3/config.yaml Outdated Show resolved Hide resolved
@tuminoid tuminoid force-pushed the tuomo/update-required-tests-ironic-image branch from 1234b40 to 90bbed7 Compare April 12, 2024 05:23
@tuminoid
update ironic-image required tests
baf7c2c 
Remove optional tests as they conflict with required tests, and don't
make much sense anyways.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/update-required-tests-ironic-image branch from 90bbed7 to baf7c2c Compare April 12, 2024 05:31
@tuminoid
Copy link
Member Author

OK, fixed the confusion with the jenkins contexts and prow contexts. How about now?

lentzi90
lentzi90 reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
Rozzii
Rozzii approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member Author

/override test-ubuntu-integration-main
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 40df7e7 into metal3-io:main Apr 12, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Update ironic-image required tests to Prow tests. Remove optional tests as they conflict with required tests, and make little sense to be available cross-releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/update-required-tests-ironic-image branch April 12, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 requested changes

@Rozzii Rozzii Rozzii approved these changes

@kashifest kashifest Awaiting requested review from kashifest

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @lentzi90 @Rozzii