Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s-prow images as needed #777

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Update k8s-prow images as needed #777

merged 1 commit into from
Jun 18, 2024

Conversation

metal3-io-bot
Copy link
Collaborator

Multiple distinct gcr.io/k8s-prow/ changes:

Commits Dates Images
13cd3ac...a9bd71b 2024‑04‑09 → 2024‑05‑13 commenter, label_sync
4359601...8e43f4d 2024‑04‑30 → 2024‑05‑31 checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, jenkins-operator, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

Nobody is currently oncall, so falling back to Blunderbuss.

Bumping k8s-prow images
47acb4b 
Multiple distinct gcr.io/k8s-prow/ changes:

Commits | Dates | Images
--- | --- | ---
metal3-io/project-infra@13cd3ac...a9bd71b | 2024‑04‑09 → 2024‑05‑13 | commenter, label_sync
metal3-io/project-infra@4359601...8e43f4d | 2024‑04‑30 → 2024‑05‑31 | checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, jenkins-operator, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

Signed-off-by: ci-robot <ci-robot@k8s.io>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 1, 2024
tuminoid
tuminoid reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

When merged, needs to be applied.

@metal3-io-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
Sunnatillo
Sunnatillo reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@Sunnatillo
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator Author

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sunnatillo
Copy link
Member

/hold
@smoshiur1237 Can we apply this?

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@metal3-io-bot metal3-io-bot merged commit a6b616f into metal3-io:main Jun 18, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator Author

@metal3-io-bot: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Multiple distinct gcr.io/k8s-prow/ changes:

Commits Dates Images
13cd3ac...a9bd71b 2024‑04‑09 → 2024‑05‑13 commenter, label_sync
4359601...8e43f4d 2024‑04‑30 → 2024‑05‑31 checkconfig, cherrypicker, clonerefs, crier, deck, entrypoint, generic-autobumper, ghproxy, hook, horologium, initupload, jenkins-operator, needs-rebase, prow-controller-manager, sidecar, sinker, status-reconciler, tide

Nobody is currently oncall, so falling back to Blunderbuss.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@NymanRobin
Copy link
Member

@Sunnatillo @smoshiur1237 I think this was never applied, I noticed it while testing to diff my other PR #821

When diffing current main against the prow cluster I get the following:

-        image: gcr.io/k8s-prow/crier:v20240430-4359601d0
+        image: gcr.io/k8s-prow/crier:v20240531-8e43f4d08

I can apply it unless there is objections

NymanRobin
NymanRobin reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@NymanRobin NymanRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the config now, let's keep an eye on this!

@smoshiur1237
Copy link
Member

/test ?

@NymanRobin NymanRobin mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@NymanRobin NymanRobin NymanRobin left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metal3-io-bot @Sunnatillo @NymanRobin @smoshiur1237 @tuminoid