Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift kubernetes version to v1.31.0 for image building #836

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Uplift kubernetes version to v1.31.0 for image building #836

merged 1 commit into from
Aug 14, 2024

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Aug 14, 2024 •
edited
Loading

Uplifts Uplift kubernetes version to v1.31.0 for image building. Also uplifts crio and crictl

Part of: metal3-io/cluster-api-provider-metal3#1887

@Sunnatillo
Uplift kubernetes version to v1.31.0 for image building
2c6ca09 
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2024
@Sunnatillo
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main
Not related test

@metal3-io-bot
Copy link
Collaborator

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
Not related test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Sunnatillo
Copy link
Member Author

/cc @tuminoid @adilGhaffarDev @mquhuy

@Sunnatillo
Copy link
Member Author

I built both centos and ubuntu images locally. It should be fine.

@Sunnatillo Sunnatillo mentioned this pull request Aug 14, 2024
Open
49 tasks
@adilGhaffarDev
Copy link
Member

/lgtm
/approve

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
@adilGhaffarDev
Copy link
Member

can you add in pr description part of metal3-io/cluster-api-provider-metal3#1887

smoshiur1237
smoshiur1237 reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kashifest
kashifest reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@metal3-io-bot metal3-io-bot merged commit 875a3d2 into metal3-io:main Aug 14, 2024
7 checks passed
@Sunnatillo Sunnatillo deleted the uplift-k8s-version-for-img-building/sunnat branch August 14, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@Rozzii Rozzii Awaiting requested review from Rozzii

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mquhuy mquhuy Awaiting requested review from mquhuy

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sunnatillo @metal3-io-bot @adilGhaffarDev @kashifest @smoshiur1237