#51 use --disable-march-tune-native for sassc building #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CAMOBAP
commented
Feb 22, 2020
CAMOBAP
commented
- Segfaults since metanorma/metanorma:1.2.8.5 #51
CAMOBAP
force-pushed
the
bugfix/rebuild-sassc
branch
from
d56057c
to
dd34d42
Compare
abunashir
approved these changes
Feb 22, 2020
CAMOBAP
force-pushed
the
bugfix/rebuild-sassc
branch
6 times, most recently
from
7bb07a2
to
fc420ae
Compare
CAMOBAP
force-pushed
the
bugfix/rebuild-sassc
branch
from
fc420ae
to
ad762af
Compare
|
@ronaldtse I have added a temporary test in ad762af and looks like this fix works Maybe we should add testing for all available samples repositories (mn-samples-*) ? |
Yes please do. Let's merge this first. Can you tag it so it builds? Thanks! |
ronaldtse
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.