Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visitor stats for multiple versions is shown for correct version #561

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

mfts
Copy link
Owner

@mfts mfts commented Aug 13, 2024

No description provided.

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 5:04pm

Copy link

what-the-diff bot commented Aug 13, 2024

PR Summary

  • Introduction of 'versionNumber' variable and parameter in multiple files
    This PR introduces a new variable and parameter titled 'versionNumber'. This has been added in several files including bar-chart-tooltip.tsx, bar-chart.tsx, visitor-chart.tsx, and functions like useDocumentThumbnail and renameSumDurationKey. This new parameter enables these functions to handle different versions of documents.

  • Conditional Rendering changes in add-document-modal.tsx
    The logic to render a specific section in the add-document-modal.tsx file has been updated. Now, this section will only be displayed if the newVersion is not true. This change aids in UI controls based on the document version state.

  • Addition of document version display in visitors-table.tsx
    In the visitors-table.tsx file, a new section has been added that now displays the document's version number. This enhancement provides users with pertinent information about the document version they are working with.

  • Modifications in getFileForDocumentPage function and API
    The getFileForDocumentPage function in the get-file-helper.ts file has been revamped to accept an optional versionNumber parameter. Moreover, the API route in the get-thumbnail.ts file has been modified to accept an optional versionNumber query parameter. These modifications improve the system's ability to cater to different versions of the documents.

@mfts mfts merged commit a8a8bde into main Aug 13, 2024
2 checks passed
@mfts mfts deleted the fix/version-views branch September 3, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant