-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup unsupported python code (except for adodbapi) #1990
Merged
Merged
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
30f43b8
Cleanup unsupported python code
Avasam 5a9fa22
Merge branch 'main' into obsolete-python-code
Avasam 03400f1
Revert sorting and organizing imports. leave that to #1986
Avasam c843fdb
Merge branch 'main' of https://github.com/mhammond/pywin32 into obsol…
Avasam 3e0dbf5
re-run `black .`
Avasam 9b7eb37
manual formatting fixes
Avasam a9e5428
Merge branch 'main' of https://github.com/mhammond/pywin32 into obsol…
Avasam dd4eee6
Merge branch 'main' into obsolete-python-code
Avasam a4c5c68
test
Avasam 0d96ceb
Extract raw string changes
Avasam 172ac3b
Fix post-merge leftovers
Avasam 52f14cd
Use bytes-string for constant bytes values
Avasam 88289d2
Merge branch 'bytes-string' of https://github.com/Avasam/pywin32 into…
Avasam 09f2456
Run formatters
Avasam bd4bd3b
Merge branch 'bytes-string' of https://github.com/Avasam/pywin32 into…
Avasam 3fb1140
Spotted a couple typos
Avasam 503b62e
Merge branch 'main' of https://github.com/mhammond/pywin32 into obsol…
Avasam 8246c1d
Found another r string to revert
Avasam 1b9d623
Remove references to outdated IronPython
Avasam 5d59f04
Address PR comments
Avasam 0672e24
Merge branch 'main' into obsolete-python-code
Avasam a00aba5
Merge branch 'main' of https://github.com/mhammond/pywin32 into obsol…
Avasam 62a7a29
Merge branch 'obsolete-python-code' of https://github.com/Avasam/pywi…
Avasam c756342
Fix bad check in _checkItemAttributes
Avasam c2991b3
Update obsolete Python 1 comments
Avasam 73d5963
Update com/win32com/client/genpy.py
Avasam 0a17531
Merge branch 'main' of https://github.com/mhammond/pywin32 into obsol…
Avasam 9545e62
Merge branch 'obsolete-python-code' of https://github.com/Avasam/pywi…
Avasam a4f02f6
Improved HLIFunction.GetSubList
Avasam 2b338a7
Missed two comments
Avasam 15ea614
Merge branch 'main' of https://github.com/mhammond/pywin32 into remov…
Avasam e804bb7
Merge branch 'remove-ironpython' into obsolete-python-code
Avasam 337d9cc
__nonzero__ to __bool__
Avasam 7510c94
Revert adodbapi changes
Avasam 0ecc5ab
Update Pythonwin/Scintilla/src/LexGen.py
Avasam 0ed39d0
Address some PR comments
Avasam 611bef2
Merge branch 'obsolete-python-code' of https://github.com/Avasam/pywi…
Avasam 44c3a53
More PR comments
Avasam 6b60a57
Remove todo comment we won't touch
Avasam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you actually test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raw_input
doesn't exist on python 3. Sowas the only code that can run.
Win32Input
is no longer used.The concept of raw input vs regular input doesn't exist in python 3. So the name didn't make sense anymore. So I removed the old unused
Win32Input
and renamedWin32RawInput
toWin32Input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, thanks, I understood the intent - I was just wondering if you actually checked that, eg,
input("enter something:")
from the interactive window still actually worked? Sadly I have no windows machine handy at the moment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. No I had not tested this "as a user would" through the app. I've only validated my understanding of small sections.
Now I did, there you go: