Simplify simple functions by using assignments #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
remove-MakeMethod
branch
from
1fb650e
to
2308b35
Compare
Avasam
changed the title
MakeMethod left behind
Avasam
commented
Mar 17, 2024
Comment on lines
-67
to
-68
| def MakeMethod(func, inst, cls): | ||
| return types.MethodType(func, inst) |
There was a problem hiding this comment.
This really should've been removed with 9a11ef0
Avasam
commented
Mar 17, 2024
| return isinstance(obj, (types.FunctionType, types.MethodType)) | ||
| # ignore hasattr(obj, "__call__") as this means all COM objects! | ||
| # ignore hasattr(obj, "__call__") as this means all COM objects! | ||
| _CallableTypes = (types.FunctionType, types.MethodType) |
There was a problem hiding this comment.
This is gonna be beneficial for type-checkers too! (Either that or making this function a TypeGuard)
This was referenced Apr 24, 2024
mhammond
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.