Fix lack of implicit anchoring of patterns to directory separators #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pattern without "*" - like "o.py" - carries an implicit assumption (not clearly documented in https://git-scm.com/docs/gitignore) that it should match a complete directory entry, and not freely match within an entry's name, i.e. it should match "o.py", but not "foo.py" or "o.pyc". To accomplish this, ensure that the pattern only matches at the start of the path, or directly following a directory separator.
This was referenced Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a different fix to issue #10 than what is currently in
PR #11. Not sure which solution is more correct/preferable.
Commits:
DeprecationWarning: invalid escape sequence '\/'