Optionally Ignore unknown TrackTypes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .mov). Also implement explicit Exception type for unknown track types. Optional parameters used to determine if exception is thrown, or unknown tracks are simply skipped (likely preferred).
… an unknown type.
|
Thanks for PR, LGTM, before merging could you:
|
…d unit tests for new parameter, and added Output type to normal parsing.
|
Ok added documentation for the parameters, some unit tests, and any other minor style fixes. |
mhor
added a commit
that referenced
this pull request
Jun 13, 2015
Optionally Ignore unknown TrackTypes
|
Thanks @nicholi. Merge in master (relased in 1.3.0) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an explicit typed exception to be caught in order to ignore unknown track types. Since you didn't have the Other (or Menu) section types implemented these will just throw exceptions making the library almost useless.
I also implemented the Other type as I wanted to use it. However Menu is still unimplemented, and any other strange sections MediaInfo might have in the future. My suggestion, make it ignore unknown track types by default rather than throw an exception. As you'll see I made the parameters to ignore optional and set to false, so it copies the current behavior.