Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed overriding attributes #36

Closed
wants to merge 1 commit into from
Closed

Conversation

petrofcz
Copy link

@petrofcz petrofcz commented Dec 3, 2015

Sometimes, multiple duration fields are returned by mediainfo.

bug-short.txt
bug.txt

@mhor
Copy link
Owner

mhor commented Dec 4, 2015

Thanks for your feedback, IMO this is not the best way to fix this bug.

The value is overridden because <DURATION> markup case is different. The good fix is probably to sanitize mediainfo data returned by AbstractXmlOutputParser::transformToArray
to merge attributes.

More information:
dump of your mediainfo output
currently tested mediainfo output

@mhor mhor added the bug label Dec 4, 2015
@mhor mhor closed this in #38 Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants