Fix attributes type #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greg0ire could you review my pull request. If it's ok for you I will merge the PR, and release a new |
greg0ire
suggested changes
Jan 14, 2017
| @@ -14,11 +14,11 @@ class Duration implements AttributeInterface | |||
| private $milliseconds; | |||
|
|
|||
| /** | |||
| * @param $duration | |||
| * @param string $duration | |||
There was a problem hiding this comment.
string|int, because the class should not know what it will be called with. In php7, you will use int as type hinting (which accepts numeric strings IIRC)
There was a problem hiding this comment.
By default, PHP will coerce values of the wrong type into the expected scalar type if possible. For example, a function that is given an integer for a parameter that expects a string will get a variable of type string.
So when you drop php 5 (on next major release?), you can safely add int as type hinting indeed.
greg0ire
approved these changes
Jan 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related (#65)