Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruby 3.3 to CI and and supported versions #32

Merged
merged 1 commit into from
May 20, 2024
Merged

Add ruby 3.3 to CI and and supported versions #32

merged 1 commit into from
May 20, 2024

Conversation

leonovk
Copy link
Contributor

@leonovk leonovk commented May 19, 2024

No description provided.

AlexWayfer
AlexWayfer approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@AlexWayfer AlexWayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little note: should we lock Ruby version in gemspec? Something like < 4.

@michaelherold
Copy link
Owner

I don't like locking by max Ruby version. I'd rather have people come report an issue with a new version.

Given what this gem does, it shouldn't have an issue unless Ruby Core changes the interface of the garbage collector, which isn't likely.

@michaelherold
Copy link
Owner

Thanks for the contribution!

@michaelherold michaelherold merged commit 100f5c6 into michaelherold:main May 20, 2024
8 checks passed
@leonovk leonovk deleted the add-ruby-3.3-to-support-versions branch May 20, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWayfer AlexWayfer AlexWayfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonovk @michaelherold @AlexWayfer