Fix compiler warnings

michel-kraemer · Oct 31, 2022 · c429b67 · c429b67
1 parent 7102f83
commit c429b67
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/citeproc-java-tool/src/main/java/de/undercouch/citeproc/tool/ShellCommand.java b/citeproc-java-tool/src/main/java/de/undercouch/citeproc/tool/ShellCommand.java
@@ -28,7 +28,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.OutputStream;
-import java.io.OutputStreamWriter;
 import java.io.PrintStream;
 import java.io.PrintWriter;
 import java.util.ArrayList;
@@ -154,7 +153,7 @@ private void mainLoop(LineReader reader, PrintWriter cout) throws IOException {
 
             Command cmd;
             try {
-                cmd = cmdClass.newInstance();
+                cmd = cmdClass.getDeclaredConstructor().newInstance();
             } catch (Exception e) {
                 // should never happen
                 throw new RuntimeException(e);

diff --git a/...proc-java-tool/src/main/java/de/undercouch/citeproc/tool/shell/ShellCommandCompleter.java b/...proc-java-tool/src/main/java/de/undercouch/citeproc/tool/shell/ShellCommandCompleter.java
@@ -98,7 +98,7 @@ public void complete(LineReader reader, ParsedLine line, List<Candidate> candida
                     Completer.class.isAssignableFrom(pr.getLastCommand())) {
                 Completer cc;
                 try {
-                    cc = (Completer)pr.getLastCommand().newInstance();
+                    cc = (Completer)pr.getLastCommand().getDeclaredConstructor().newInstance();
                 } catch (Exception e) {
                     // should never happen
                     throw new RuntimeException(e);

diff --git a/citeproc-java-tool/src/main/java/de/undercouch/citeproc/tool/shell/ShellHelpCommand.java b/citeproc-java-tool/src/main/java/de/undercouch/citeproc/tool/shell/ShellHelpCommand.java
@@ -87,7 +87,7 @@ public int doRun(String[] remainingArgs, InputReader in, PrintWriter out)
         CSLToolCommand cmd = null;
         if (cmdClass != null) {
             try {
-                cmd = (CSLToolCommand)cmdClass.newInstance();
+                cmd = (CSLToolCommand)cmdClass.getDeclaredConstructor().newInstance();
             } catch (Exception e) {
                 // should never happen
                 throw new RuntimeException(e);

diff --git a/citeproc-java/src/main/java/de/undercouch/citeproc/bibtex/PageRange.java b/citeproc-java/src/main/java/de/undercouch/citeproc/bibtex/PageRange.java
@@ -15,6 +15,7 @@ public class PageRange {
      * Constructs a range of pages
      * @param literal the string from which this range has been created
      * @param pageFirst the first page in the range (can be {@code null})
+     * @param pageLast the last page in the range (can be {@code null})
      * @param numberOfPages the number of pages in this range (can be {@code null})
      * @param multiplePages {@code true} if this object represents multiple
      * pages (may be {@code true} even if the actual {@code numberOfPages}