Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar colors #2153

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

sergio-costas
Copy link
Collaborator

@sergio-costas sergio-costas commented Mar 1, 2024

As commented in ubuntu/yaru#4016, the progress bar, with its 3D gradient track, doesn't fit very well in the current Gnome/Yaru theme.

This patch changes this, allowing to set all the colors in the bars using CSS: the background color and outline width and color both for the track and the progress bar itself, and also use either plain colors or gradients in each of the four elements, allowing to also specify the start and stop points.

imagen

@sergio-costas
Copy link
Collaborator Author

Ok, I did some extra changes and now it allows to set all the colors using CSS. It is possible to choose between plain colors or gradients, and more.

@sergio-costas
Copy link
Collaborator Author

@jbicha Can you review this when you have some spare time, please?

@sergio-costas
Copy link
Collaborator Author

@3v1n0 Or you, Marco, can you review this when you have some spare time, please?

appIconIndicators.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@3v1n0 3v1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some cleanups but indeed it is an improvement!

appIconIndicators.js Outdated Show resolved Hide resolved
appIconIndicators.js Outdated Show resolved Hide resolved
appIconIndicators.js Outdated Show resolved Hide resolved
appIconIndicators.js Outdated Show resolved Hide resolved
appIconIndicators.js Outdated Show resolved Hide resolved
appIconIndicators.js Outdated Show resolved Hide resolved
_stylesheet.scss Show resolved Hide resolved
As commented in ubuntu/yaru#4016, the
progress bar, with its 3D gradient track, doesn't fit very well
in the current Gnome/Yaru theme.

This patch changes this, moving the track to a planar look, and
also allows to set the colors in the CSS.
@3v1n0
Copy link
Collaborator

3v1n0 commented Mar 21, 2024

Thanks, let's get this in!

@3v1n0 3v1n0 merged commit 554f7c5 into micheleg:master Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants