Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Add validation rules for DNA Container Label #161

Closed
pvangay opened this issue Feb 10, 2022 · 2 comments
Closed

Add validation rules for DNA Container Label #161

pvangay opened this issue Feb 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working patterns serializations regexes SNTC edit can be resolved by making edits to Soil-NMDC-Template_Compiled google sheet

Comments

@pvangay
Copy link

pvangay commented Feb 10, 2022

Currently the guidance for DNA Container Labels states that the values must be unique and less than 20 characters. There appears to be no validation for this term because values > 20 characters or duplicate values validate just fine.

image

@pvangay pvangay added the bug Something isn't working label Feb 10, 2022
@turbomam
Copy link
Member

Remove "<20 characters" from the guidance (implemented as a LinkML comment) or add tighter validation?

Proposed new SNTC syntax ie LinkML string_serialization: {text < 20 characters}, which would become a regular expression or LinkML pattern of ^.{1,20}$

See also linkml/linkml#176

@turbomam turbomam added SNTC edit can be resolved by making edits to Soil-NMDC-Template_Compiled google sheet patterns serializations regexes labels Feb 10, 2022
@pkalita-lbl
Copy link
Collaborator

This appears to be fixed now. A plate name longer than 20 characters fails validation. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working patterns serializations regexes SNTC edit can be resolved by making edits to Soil-NMDC-Template_Compiled google sheet
Projects
None yet
Development

No branches or pull requests

3 participants