-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GOLD 'ecosystem' slots at study level #403
Comments
Hi, @mslarae13 Yes, it could be confusing. Even worse, nothing's in place to make sure that the biosample GOLD ecosystem paths are compatible with the study GOLD ecosystem paths There's some good discussion of this in #10 |
@mslarae13 GOLD specifies these terms at the study level |
@aclum so the term that is identified at the study level gets applied to all the biosamples? Or can biosamples in a study differ from the study? @turbomam thanks, I don't think I saw that discussion... still seems weird to me. You can have a pretty wide variation among biosamples depending on your research questions within your study. If the study is assigned, and biosamples.. then that kinda makes sense to me. TO assign at only the study level seems weird. |
BIosamples classification can be more specific that study. For example for Gs0161344 we have
The biosamples w/in the study have Ecosystem Subtype specified
|
Ok. in that case, I think this is fine then. Since we pull it from GOLD and it's at both biosample and study level |
Why are the 5 GOLD ecosystem terms captured under study class? https://microbiomedata.github.io/nmdc-schema/Study/
Biosample makes sense. https://microbiomedata.github.io/nmdc-schema/Biosample/
But with study is confusing to me.
Should these be deprecated?
@turbomam
@emileyfadrosh
@cmungall
The text was updated successfully, but these errors were encountered: