Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOLD 'ecosystem' slots at study level #403

Closed
Tracked by #587
mslarae13 opened this issue Aug 12, 2022 · 5 comments
Closed
Tracked by #587

GOLD 'ecosystem' slots at study level #403

mslarae13 opened this issue Aug 12, 2022 · 5 comments
Labels
gold schema change Term updates to NMDC Schema

Comments

@mslarae13
Copy link
Contributor

Why are the 5 GOLD ecosystem terms captured under study class? https://microbiomedata.github.io/nmdc-schema/Study/
Biosample makes sense. https://microbiomedata.github.io/nmdc-schema/Biosample/
But with study is confusing to me.

Should these be deprecated?

  • this might be a quick to close issue if I'm just misunderstanding something

@turbomam
@emileyfadrosh
@cmungall

@mslarae13 mslarae13 added the schema change Term updates to NMDC Schema label Aug 12, 2022
@turbomam
Copy link
Member

Hi, @mslarae13

Yes, it could be confusing. Even worse, nothing's in place to make sure that the biosample GOLD ecosystem paths are compatible with the study GOLD ecosystem paths

There's some good discussion of this in #10

@mslarae13 mslarae13 mentioned this issue Jan 18, 2023
99 tasks
@turbomam turbomam added the gold label Feb 16, 2023
@aclum
Copy link
Contributor

aclum commented Jul 3, 2023

@mslarae13 GOLD specifies these terms at the study level
see
https://gold.jgi.doe.gov/study?id=Gs0161344

@mslarae13
Copy link
Contributor Author

@aclum so the term that is identified at the study level gets applied to all the biosamples?
Is that true for the lower levels?

Or can biosamples in a study differ from the study?

@turbomam thanks, I don't think I saw that discussion... still seems weird to me. You can have a pretty wide variation among biosamples depending on your research questions within your study. If the study is assigned, and biosamples.. then that kinda makes sense to me. TO assign at only the study level seems weird.

@aclum
Copy link
Contributor

aclum commented Jul 7, 2023

BIosamples classification can be more specific that study. For example

for Gs0161344 we have

Ecosystem Environmental
Ecosystem Category Terrestrial
Ecosystem Type Soil
Ecosystem Subtype Unclassified
Specific Ecosystem Unclassified
Ecosystem Path ID 4212

The biosamples w/in the study have Ecosystem Subtype specified
ex Gb0356235

Ecosystem Environmental
Ecosystem Category Terrestrial
Ecosystem Type Soil
Ecosystem Subtype Tundra
Specific Ecosystem Unclassified
Ecosystem Path Id 5950

@mslarae13
Copy link
Contributor Author

Ok. in that case, I think this is fine then. Since we pull it from GOLD and it's at both biosample and study level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gold schema change Term updates to NMDC Schema
Projects
None yet
Development

No branches or pull requests

3 participants