Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated source_mat_id on submission portal #157

Closed
Tracked by #587 ...
mslarae13 opened this issue Oct 3, 2022 · 4 comments
Closed
Tracked by #587 ...

Updated source_mat_id on submission portal #157

mslarae13 opened this issue Oct 3, 2022 · 4 comments
Assignees

Comments

@mslarae13
Copy link

I've updated the description & guidance for source_mat_id.

See: https://docs.google.com/spreadsheets/d/1cMlPKgjZh-v21aMYCm9x1TxzE5BwGQptBQcvuaYAtC8/edit#gid=1241218612
Row 77, 78, 79

In accordance with microbiomedata/nmdc-schema#372 feedback.

Updates need added to data harmonizer and the submission portal.

@mslarae13
Copy link
Author

Adding to SubPort squad. I think this is done? Need to confirm.

@mslarae13 mslarae13 self-assigned this Jan 4, 2023
@turbomam
Copy link
Member

turbomam commented Jan 5, 2023

This issue mentions the following issue with closed status:

But neither this issue or the linked issue mention a PR. If there was a merged PR, that's usually strong grounds to close all linked issues. But we'll have do some manual double checking in this case.

@mslarae13
Copy link
Author

Did a quick check! Looks like I edited the linked google sheet https://docs.google.com/spreadsheets/d/1cMlPKgjZh-v21aMYCm9x1TxzE5BwGQptBQcvuaYAtC8/edit?usp=sharing

But made no changes to the schema. I can go ahead and make a branch for this and update it in the schema.

@mslarae13
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ SubPort 1 - Done
Development

No branches or pull requests

2 participants