Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTLP registry publishes incorrect delta values on close #3773

Closed
shakuzen opened this issue Apr 17, 2023 · 0 comments · Fixed by #3798
Closed

OTLP registry publishes incorrect delta values on close #3773

shakuzen opened this issue Apr 17, 2023 · 0 comments · Fixed by #3798
Labels
bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Milestone
1.11.0

Comments

@shakuzen
Copy link
Member

See #3625 (review). The fix made in #1882 does not currently help OtlpMeterRegistry because it does not extend StepMeterRegistry.
@shakuzen shakuzen added bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related labels Apr 17, 2023
@shakuzen shakuzen added this to the 1.11.0 milestone Apr 17, 2023
@jonatan-ivanov jonatan-ivanov mentioned this issue May 2, 2023
Merged
jonatan-ivanov added a commit to jonatan-ivanov/micrometer that referenced this issue May 2, 2023
@jonatan-ivanov
Publish values on close in OTLP registry
d14561b 
The fix for partial publish on close was not applied to OTLP registry.

Closes micrometer-metricsgh-3773
See micrometer-metricsgh-1882
@lenin-jaganathan lenin-jaganathan mentioned this issue May 2, 2023
Merged
jonatan-ivanov added a commit to jonatan-ivanov/micrometer that referenced this issue May 4, 2023
@jonatan-ivanov
Publish values on close in OTLP registry
0b5df4f 
The fix for partial publish on close was not applied to OTLP registry.

Closes micrometer-metricsgh-3773
See micrometer-metricsgh-1882
jonatan-ivanov added a commit that referenced this issue May 4, 2023
@jonatan-ivanov
Publish values on close in OTLP registry (#3798)
234b148 
The fix for partial publish on close was not applied to OTLP registry.

Closes gh-3773
See gh-1882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

Publish values on close in OTLP registry jonatan-ivanov/micrometer
1 participant
@shakuzen