Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @Counted on classes #4746

Closed
shakuzen opened this issue Feb 13, 2024 · 0 comments · Fixed by #4758
Closed

Support @Counted on classes #4746

shakuzen opened this issue Feb 13, 2024 · 0 comments · Fixed by #4758
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Milestone
1.13.0-M2

Comments

@shakuzen
Copy link
Member

shakuzen commented Feb 13, 2024 •
edited
Loading

See #4502.

Allow the @Counted annotation on classes, and update our CountedAspect implementation to handle when @Counted is on a class.
@shakuzen shakuzen added enhancement A general enhancement help wanted An issue that a contributor can help us with module: micrometer-core An issue that is related to our core module labels Feb 13, 2024
@shakuzen shakuzen added this to the 1.x milestone Feb 13, 2024
@shakuzen shakuzen mentioned this issue Feb 13, 2024
Closed
izeye added a commit to izeye/micrometer that referenced this issue Feb 19, 2024
@izeye
Support @counted on classes
8a2a632 
See micrometer-metricsgh-4746
izeye added a commit to izeye/micrometer that referenced this issue Feb 19, 2024
@izeye
Support @counted on classes
205f6a2 
See micrometer-metricsgh-4746
@izeye izeye mentioned this issue Feb 19, 2024
Merged
@shakuzen shakuzen modified the milestones: 1.x, 1.13.0-M2 Feb 20, 2024
@shakuzen shakuzen changed the title Support @Counted on more types Support @Counted on classes Feb 20, 2024
@shakuzen shakuzen linked a pull request Feb 20, 2024 that will close this issue
Support @Counted on classes #4758
Merged
shakuzen pushed a commit that referenced this issue Feb 20, 2024
@izeye
Support @counted on classes in CountedAspect (#4758)
509d45d 
Resolves gh-4746
@shakuzen shakuzen removed the help wanted An issue that a contributor can help us with label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.13.0-M2
Development

Successfully merging a pull request may close this issue.

Support @Counted on classes izeye/micrometer
1 participant
@shakuzen