Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary mockito dependency in micrometer-test #4963

Closed
shakuzen opened this issue Apr 15, 2024 · 0 comments
Closed

Remove unnecessary mockito dependency in micrometer-test #4963

shakuzen opened this issue Apr 15, 2024 · 0 comments
Labels
enhancement A general enhancement module: micrometer-test An issue that is related to our TCK
Milestone

Comments

@shakuzen
Copy link
Member

We declare an api dependency on mockito-core but it is unused in the micrometer-test module. We should be able to remove this unused dependency.

api 'org.mockito:mockito-core'

Some of our other modules were depending on the mockito dependency being pulled in via micrometer-test, but that should not have been the case. If a module uses mockito in its own test code, it should declare a test dependency on mockito.

@shakuzen shakuzen added enhancement A general enhancement module: micrometer-test An issue that is related to our TCK labels Apr 15, 2024
@shakuzen shakuzen added this to the 1.13.0 milestone Apr 15, 2024
jonatan-ivanov added a commit to jonatan-ivanov/micrometer that referenced this issue Apr 23, 2024
jonatan-ivanov added a commit that referenced this issue Apr 24, 2024
Mockito 5 is not compatible with Java 8.

Closes gh-4968
See gh-4963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement module: micrometer-test An issue that is related to our TCK
Projects
None yet
Development

No branches or pull requests

1 participant