ObservationContextAssert now asserts ContextView, add parentObservation assertions #3304
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
||
| public SELF hasParentObservationContextMatching(Predicate<? super Observation.ContextView> parentContextViewPredicate, String description) { | ||
| hasParentObservation(); | ||
| ObservationContextAssert.assertThat(this.actual.getParentObservation().getContext()) |
There was a problem hiding this comment.
NULL_DEREFERENCE: object returned by AbstractAssert.actual.getParentObservation() could be null and is dereferenced at line 387.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| if (realParent == null) { | ||
| failWithMessage("Observation should have parent <%s>, has none", expectedParent); | ||
| } | ||
| if (!realParent.equals(expectedParent)) { |
There was a problem hiding this comment.
NULL_DEREFERENCE: object realParent last assigned on line 353 could be null and is dereferenced at line 357.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| public SELF hasParentObservationContextSatisfying(ThrowingConsumer<? super Observation.ContextView> parentContextViewAssertion) { | ||
| hasParentObservation(); | ||
| assertThat(this.actual.getParentObservation().getContext()) |
There was a problem hiding this comment.
NULL_DEREFERENCE: object returned by AbstractAssert.actual.getParentObservation() could be null and is dereferenced at line 373.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| public SELF hasParentObservationContextMatching(Predicate<? super Observation.ContextView> parentContextViewPredicate) { | ||
| hasParentObservation(); | ||
| assertThat(this.actual.getParentObservation().getContext()) |
There was a problem hiding this comment.
NULL_DEREFERENCE: object returned by AbstractAssert.actual.getParentObservation() could be null and is dereferenced at line 380.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
shakuzen
added
enhancement
This comment was marked as resolved.
This comment was marked as resolved.
| public SELF hasParentObservationContextMatching( | ||
| Predicate<? super Observation.ContextView> parentContextViewPredicate, String description) { | ||
| Observation p = checkedParentObservation(); | ||
| if (!parentContextViewPredicate.test(p.getContext())) { |
There was a problem hiding this comment.
NULL_DEREFERENCE: object p last assigned on line 441 could be null and is dereferenced at line 442.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| ThrowingConsumer<Observation.ContextView> parentContextViewAssertion) { | ||
| Observation p = checkedParentObservation(); | ||
| try { | ||
| parentContextViewAssertion.accept(p.getContext()); |
There was a problem hiding this comment.
NULL_DEREFERENCE: object p last assigned on line 406 could be null and is dereferenced at line 408.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| public SELF hasParentObservationContextMatching( | ||
| Predicate<? super Observation.ContextView> parentContextViewPredicate) { | ||
| Observation p = checkedParentObservation(); | ||
| if (!parentContextViewPredicate.test(p.getContext())) { |
There was a problem hiding this comment.
NULL_DEREFERENCE: object p last assigned on line 426 could be null and is dereferenced at line 427.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
This PR changes the target type of
ObservationContextAsserttoContextView.The Assert doesn't need the writable aspect of
Context, and this switch allowsusage of the Assert on
Observation#getContext().As a result, we can reuse the Assert on
actual.getParentObservation().getContext()when the user passes a
Predicateor an assertingConsumeraimed at the parent.This PR then introduces various assertions around the
getParentObservation().TODO: