Generify throwable in CheckedCallable/CheckedRunnable #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows usage that catches or throws more a more specific type than `Throwable`. This is a bit more verbose when declaring a variable of type CheckedCallable or CheckedRunnable, but I expect most usage to be as a lambda or method reference, which avoids the need to do such.
shakuzen
commented
Aug 2, 2022
| String s = observation.scopedChecked(service::executeCallable); | ||
| observation.scopedChecked(service::executeRunnable); | ||
| } | ||
| catch (IOException ignore) { |
There was a problem hiding this comment.
This wasn't possible before due to it being hard-coded to Throwable
jonatan-ivanov
approved these changes
Aug 2, 2022
...on-test/src/main/java/io/micrometer/observation/tck/ObservationRegistryCompatibilityKit.java
Show resolved
Hide resolved
Make it explicit whether CheckedRunnable or CheckedCallable is being tested and avoid the wrong overload of the method being called in the test.
|
This is a breaking change if someone is declaring a Observation.CheckedCallable<String> callable = () -> {
assertThat(registry.getCurrentObservation()).isNull();
return "test";
};CheckedRunnable will still compile because it had 0 before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows usage that catches or throws more a more specific type than
Throwable. This is a bit more verbose when declaring a variable of typeCheckedCallableorCheckedRunnable, but I expect most usage to be as a lambda or method reference, which avoids the need to do such.@jonatan-ivanov let me know what you think. I may have overlooked some reason why not to do this. This change wasn't based on user feedback, so I don't feel strongly about doing this but I figured I would open the proposal for discussion.