Add "createNotStarted" method that lazily creates context #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttddyy
force-pushed
the
create-not-started
branch
from
fe0dd1c
to
5b6a70f
Compare
| * @param registry observation registry | ||
| * @return observation | ||
| */ | ||
| default <T extends Observation.Context> Observation createNotStarted( |
There was a problem hiding this comment.
Can we also add a null check since the registry is @Nullable? See:
Also, should not we do this in the Observation too?
There was a problem hiding this comment.
registry is non-null on this method, so don't need null check here.
I'll add documentation that this no-op registry check is a quick check and further decision(ObservationPredicate) would happen after context is created.
There was a problem hiding this comment.
I'll go to an eye doctor. :D
| * @param registry observation registry | ||
| * @return observation | ||
| */ | ||
| default <T extends Observation.Context> Observation createNotStarted( |
There was a problem hiding this comment.
I think we should call these methods createNotStarted but I'm not sure we all agreed on that.
I think either we call all of them createNotStarted or observation.
Add another variant of "observation" method to delay the observation context creation. When the registry is a no-op, it fast returns the no-op observation and skips calling the supplier. This avoids the creation of the observation context.
ttddyy
force-pushed
the
create-not-started
branch
from
5b6a70f
to
c7b7cc8
Compare
marcingrzejszczak
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another variant of
observationmethod to delay the observation context creation. When the registry is a no-op, it fast returns the no-op observation and skips calling the supplier. This avoids the creation of the observation context.Ideally, the supplier should be pushed down to more method calls to further delay the context creation, but at least this gives an API that minimize the creation of context.