Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc for ObservationThreadLocalAccessor(ObservationRegistry) #3937

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jun 26, 2023

This PR sets the instance static field in the ObservationThreadLocalAccessor(ObservationRegistry) constructor as it seems to have been missed based on its Javadoc.

@marcingrzejszczak
Copy link
Contributor

I don't think we should be setting this because for the ContextRegistry default instantiation, the default constructor will be called. If someone is manually updating a ContextRegistry then they should manually update the instance. They might also be using an instance for tests and don't want the test instance to be used in other parts of the system.

@izeye izeye changed the title Set instance static field in ObservationThreadLocalAccessor(ObservationRegistry) Fix Javadoc for ObservationThreadLocalAccessor(ObservationRegistry) Jun 26, 2023
@izeye
Copy link
Contributor Author

izeye commented Jun 26, 2023

@marcingrzejszczak Thanks for the feedback! I fixed its Javadoc instead.

@marcingrzejszczak
Copy link
Contributor

Thank you!

@marcingrzejszczak marcingrzejszczak merged commit f6e2b9b into micrometer-metrics:1.10.x Jun 26, 2023
1 check passed
@marcingrzejszczak marcingrzejszczak added the doc-update A documentation update label Jun 26, 2023
@marcingrzejszczak marcingrzejszczak added this to the 1.10.9 milestone Jun 26, 2023
@izeye izeye deleted the instance branch June 26, 2023 13:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-update A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants