Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the current timestamp for otlp gauges #5045

Merged

Conversation

lenin-jaganathan
Copy link
Contributor

Fixes #5044

Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you. I'll rebase on 1.11.x before merging so we can apply the fix for upcoming maintenance releases.

@lenin-jaganathan
Copy link
Contributor Author

Looks good. Thank you. I'll rebase on 1.11.x before merging so we can apply the fix for upcoming maintenance releases.

There was a bit of refactoring that went in the master hence I targeted master. No harm in back porting this fix just that a simple cherry pick might not work due to conflicts.

@shakuzen shakuzen changed the base branch from main to 1.11.x May 8, 2024 07:31
@shakuzen
Copy link
Member

shakuzen commented May 8, 2024

No harm in back porting this fix just that a simple cherry pick might not work due to conflicts.

Just another day in maintaining a code base with multiple branches 😁

@shakuzen shakuzen merged commit a9c08d8 into micrometer-metrics:1.11.x May 8, 2024
5 checks passed
@lenin-jaganathan lenin-jaganathan deleted the otlp_gauge_timestamp branch May 8, 2024 07:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP Gauge datapoint timestamp should be time at sampling
2 participants