Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter of failed attempts to retrieve a connection from the pool #5057

Merged

Conversation

codesimplicity
Copy link
Contributor

No description provided.

@pivotal-cla
Copy link

@codesimplicity Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@codesimplicity Thank you for signing the Contributor License Agreement!

@shakuzen shakuzen added enhancement A general enhancement module: micrometer-core An issue that is related to our core module instrumentation An issue that is related to instrumenting a component labels May 9, 2024
@shakuzen shakuzen added this to the 1.14.0-M1 milestone May 9, 2024
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. It would be good to have a test demonstrating the counter gets incremented when expected.

@codesimplicity
Copy link
Contributor Author

@shakuzen I actually have no idea why this GC related test fails, wouldn't know how this could be related to my change in any way. Also have no clue how to run those tests locally on my system or rerun them in CircleCI (without pushing another change). Any guidance would be appreciated.

@shakuzen
Copy link
Member

shakuzen commented Jul 9, 2024

@codesimplicity sorry for the long delay in responding. I have re-run the CI manually. You can amend your commit and force push to cause CI to run again for future reference. Unfortunately there isn't a better way for non-maintainers to re-run CI builds with unrelated errors.

@shakuzen shakuzen merged commit 557d997 into micrometer-metrics:main Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement instrumentation An issue that is related to instrumenting a component module: micrometer-core An issue that is related to our core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants