Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default factoryType tag in CommonsObjectPool2Metrics #5316

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Add default factoryType tag in CommonsObjectPool2Metrics #5316

merged 2 commits into from
Jul 31, 2024

Commits on Jul 31, 2024

  1. Add default factoryType tag in CommonsObjectPool2Metrics 

    There are cases where the factoryType tag is missing
which leads to issues in certain registries (i.e.: Prometheus).
This change adds a default "none" value to the factoryType tag so that
it will be always present.

See micrometer-metricsgh-5316
    @HYEONSEOK1 @jonatan-ivanov
    HYEONSEOK1 authored and jonatan-ivanov committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    dc8ee1a View commit details
    Browse the repository at this point in the history

  2. Polish CommonsObjectPool2Metrics and CommonsObjectPool2MetricsTest 

    See micrometer-metricsgh-5316
    @jonatan-ivanov
    jonatan-ivanov committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    90f3695 View commit details
    Browse the repository at this point in the history