Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates micronaut version to 3.5.2 #248

Merged
merged 7 commits into from
Jun 28, 2022
Merged

updates micronaut version to 3.5.2 #248

merged 7 commits into from
Jun 28, 2022

Conversation

grimmjo
Copy link
Collaborator

@grimmjo grimmjo commented May 23, 2022

No description provided.

@graemerocher
Copy link
Contributor

can we bump to 3.4.4 instead?

@grimmjo
Copy link
Collaborator Author

grimmjo commented May 24, 2022

Yeah sure, was my mistake 😄

@grimmjo grimmjo changed the title updates micronaut version to 3.3.4 updates micronaut version to 3.4.4 May 24, 2022
@graemerocher graemerocher requested a review from melix May 25, 2022 09:21
@grimmjo grimmjo changed the title updates micronaut version to 3.4.4 updates micronaut version to 3.5.0 May 28, 2022
@grimmjo
Copy link
Collaborator Author

grimmjo commented May 28, 2022

Hey @melix,

after upgrading to 3.5.0 there seems to be a problem with build cache. Do you have any advise?

@melix
Copy link
Contributor

melix commented May 28, 2022

This is a nasty bug in Gradle. Let's disable binary compatibility checks for this one.

@grimmjo
Copy link
Collaborator Author

grimmjo commented May 28, 2022

Can we make a clean build, e.g. without the cache in github actions? I can reproduce the problem locally.

@grimmjo
Copy link
Collaborator Author

grimmjo commented May 28, 2022

gradle/gradle#14220 might be the related issue

@melix
Copy link
Contributor

melix commented May 28, 2022

Why do you think the problem is the cache? It's a dependency resolution bug so cleaning the cache won't help.

@grimmjo
Copy link
Collaborator Author

grimmjo commented May 29, 2022

My mistake! I just saw the path in the error message last night and thought it would be a caching problem. Next time I should first read the stacktrace 😄

@grimmjo grimmjo changed the title updates micronaut version to 3.5.0 updates micronaut version to 3.5.1 Jun 5, 2022
melix
melix previously approved these changes Jun 7, 2022
@grimmjo grimmjo changed the title updates micronaut version to 3.5.1 updates micronaut version to 3.5.2 Jun 23, 2022
@grimmjo
Copy link
Collaborator Author

grimmjo commented Jun 23, 2022

@melix: Can I disable the binary compatibility checks in the build.gradle for example? 🤔

@graemerocher: Can you tell me who is responsible for merging the PRs in this repo? It looks like you are pretty busy 😃

@melix
Copy link
Contributor

melix commented Jun 23, 2022

@melix: Can I disable the binary compatibility checks in the build.gradle for example? thinking

You can: https://github.com/micronaut-projects/micronaut-build/wiki/Upgrade-guide#upgrading-to-micronaut-build-53x

micronautBuild {
    binaryCompatibility {
        enabled = false
    }
}

Alternatively you might want to try upgrading to Gradle 7.5-rc2, this fixed a similar problem for me.

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grimmjo
Copy link
Collaborator Author

grimmjo commented Jun 27, 2022

@melix: thank you so much for your help =) upgrading to gradle 7.5-rc2 solved the problem. Can you merge this PR?

config/accepted-api-changes.json Show resolved Hide resolved
@melix melix merged commit 8006913 into master Jun 28, 2022
@melix melix deleted the mnVersionUpdate branch June 28, 2022 09:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants