Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Rationalise prometheus to produce RED metrics #31

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

philwinder
Copy link
Contributor

@philwinder philwinder commented Mar 10, 2017

Metric wraps http handler to simplify interface.
Metric is a var because metrics can only be instantiated once.
Use httpsniffer to get status code.
microservices-demo/microservices-demo#422

Copy link
Contributor

@nustiueudinastea nustiueudinastea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+2.02%) to 25.263% when pulling a1b7621 on monitoring/rationalise-prometheus into 6d8a459 on master.

Metric wraps http handler to simplify interface.
Metric is a var because metrics can only be instantiated once.
Use httpsniffer to get status code.
Automatically convert url paths to route name.
@philwinder philwinder force-pushed the monitoring/rationalise-prometheus branch from a1b7621 to 7c6bd40 Compare March 13, 2017 11:14
@coveralls
Copy link

Coverage Status

Coverage increased (+2.3%) to 25.532% when pulling 7c6bd40 on monitoring/rationalise-prometheus into 6d8a459 on master.

@philwinder philwinder merged commit 057b99c into master Mar 13, 2017
@philwinder philwinder deleted the monitoring/rationalise-prometheus branch March 13, 2017 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants