Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Commit

Permalink
Merge pull request #44 from microservices-demo/refactor/remove-hystrix
Browse files Browse the repository at this point in the history
Remove hystrix circuit-breaking code to avoid 500's.
  • Loading branch information
Phil Winder committed Mar 21, 2017
2 parents ed60362 + 5e0e4d5 commit e147999
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions api/transport.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"net/http"
"strings"

"github.com/go-kit/kit/circuitbreaker"
"github.com/go-kit/kit/log"
"github.com/go-kit/kit/tracing/opentracing"
httptransport "github.com/go-kit/kit/transport/http"
Expand Down Expand Up @@ -38,70 +37,70 @@ func MakeHTTPHandler(ctx context.Context, e Endpoints, logger log.Logger, tracer

r.Methods("GET").Path("/login").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("Login")(e.LoginEndpoint),
e.LoginEndpoint,
decodeLoginRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /login", logger)))...,
))
r.Methods("POST").Path("/register").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("Register")(e.RegisterEndpoint),
e.RegisterEndpoint,
decodeRegisterRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /register", logger)))...,
))
r.Methods("GET").PathPrefix("/customers").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("UserGet")(e.UserGetEndpoint),
e.UserGetEndpoint,
decodeGetRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /customers", logger)))...,
))
r.Methods("GET").PathPrefix("/cards").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("CardGet")(e.CardGetEndpoint),
e.CardGetEndpoint,
decodeGetRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /cards", logger)))...,
))
r.Methods("GET").PathPrefix("/addresses").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("AddressGet")(e.AddressGetEndpoint),
e.AddressGetEndpoint,
decodeGetRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /addresses", logger)))...,
))
r.Methods("POST").Path("/customers").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("UserPost")(e.UserPostEndpoint),
e.UserPostEndpoint,
decodeUserRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /customers", logger)))...,
))
r.Methods("POST").Path("/addresses").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("AddressPost")(e.AddressPostEndpoint),
e.AddressPostEndpoint,
decodeAddressRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /addresses", logger)))...,
))
r.Methods("POST").Path("/cards").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("CardPost")(e.CardPostEndpoint),
e.CardPostEndpoint,
decodeCardRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "POST /cards", logger)))...,
))
r.Methods("DELETE").PathPrefix("/").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("Delete")(e.DeleteEndpoint),
e.DeleteEndpoint,
decodeDeleteRequest,
encodeResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "DELETE /", logger)))...,
))
r.Methods("GET").PathPrefix("/health").Handler(httptransport.NewServer(
ctx,
circuitbreaker.Hystrix("Health")(e.HealthEndpoint),
e.HealthEndpoint,
decodeHealthRequest,
encodeHealthResponse,
append(options, httptransport.ServerBefore(opentracing.FromHTTPRequest(tracer, "GET /health", logger)))...,
Expand Down

0 comments on commit e147999

Please sign in to comment.