Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Rationalise prometheus to produce RED metrics #43

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Rationalise prometheus to produce RED metrics #43

merged 1 commit into from
Mar 13, 2017

Conversation

philwinder
Copy link
Contributor

@philwinder philwinder commented Mar 13, 2017 •
edited

Reuse middleware.
Add histogram metric.
Measure all http calls.
microservices-demo/microservices-demo#422

@philwinder
Use standard prometheus naming
2708659 
Reuse middleware.
Add histogram metric.
Measure all http calls.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.252% when pulling 2708659 on refactoring/prometheus into ca1adfe on master.

nustiueudinastea
nustiueudinastea approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@nustiueudinastea nustiueudinastea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nustiueudinastea nustiueudinastea merged commit ed60362 into master Mar 13, 2017
@nustiueudinastea nustiueudinastea deleted the refactoring/prometheus branch March 13, 2017 13:53
@philwinder philwinder changed the title Use standard prometheus naming Rationalise prometheus to produce RED metrics Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nustiueudinastea nustiueudinastea nustiueudinastea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philwinder @coveralls @nustiueudinastea