Dynamically set object textures from existing UE material or texture PNG #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajat2004
reviewed
Aug 28, 2021
|
Thanks for the review, @rajat2004 - I've pushed some fixes! |
zimmy87
suggested changes
Nov 4, 2021
There was a problem hiding this comment.
Hi @saihv, thanks for submitting this PR, this looks like a good change to take, however I'm having trouble launching the Blocks environment with your PR checked out. I get the following error message:
---------------------------
Message
---------------------------
Default Property warnings and errors:
Error: CDO Constructor (SimModeBase): Failed to find Material'/AirSim/HUDAssets/DomainRandomizationMaterial.DomainRandomizationMaterial'
---------------------------
OK
---------------------------
I checked and confirmed that Unreal/Plugins/AirSim/Content/HUDAssets/DomainRandomizationMaterial.uasset is present in my repo and Blocks environment, but it doesn't show up in the editor. Just out of curiosity, which version of the editor are you using? There may be a version mismatch here.
recreate DomainRandomizationMaterial to make it compatible with UE 4.25
add new method stubs for setObjectMaterial APIs
zimmy87
approved these changes
Nov 9, 2021
|
I was able to test this locally and confirmed the new APIs are working as expected. Thanks for submitting this PR @saihv! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR adds API functions to dynamically change the textures of in-game objects either to existing Unreal material assets (
simSetObjectMaterial), or to arbitrary texture PNGs (simSetObjectMaterialFromTexture) - in order to help with generating data with domain randomization. Path to a.uassetor an image file (.png,.jpgetc.) should be specified based on the function being used.How Has This Been Tested?
Run AirSim with the Blocks map, and run
PythonClient/environment/change_texture_example.pyScreenshots (if appropriate):