Configured the code to work with Java 6 standards and using gradlew #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Actually our repo should not include IDE specific files to allow anyone use their own tool of choice
There was a problem hiding this comment.
Not sure about it. C# has the .sln file.
If we go with Intellij then we need to share a few files
please read: #1
There was a problem hiding this comment.
.Net sln files are used to list the projects to build.
However, as in this project we're using build.gradle as long as IntelliJ knows how to import the project from then I'm not sure that these files are really needed
gupele
added a commit
that referenced
this pull request
Dec 17, 2014
…va-6 Configured the code to work with Java 6 standards and using gradlew
3 tasks
littleaj
added a commit
that referenced
this pull request
Apr 23, 2019
pull lastest from Microsoft master
trask
pushed a commit
that referenced
this pull request
Nov 7, 2020
* apache camel 2.20.x instrumentation * removed instrumentation advice from helper classes * code review #1 * code review #2 / experimental server name update * code review changes / new tests, improved direct, new license header * rebase changes * code review changes * code review changes, REST tests added * changes after rebase to newest master * code review changes * code review * code review * rebase to master
trask
pushed a commit
that referenced
this pull request
May 26, 2021
trask
added a commit
that referenced
this pull request
Sep 12, 2022
…#2503) * Build changes needed to add an Automatic Module Name to Runtime Attach (#1) Build changes needed to add an Automatic Module Name so this library can be imported into modular java projects. * I'll build with 17 since that's what we're using for the modular app that needs this. * going back to 8 since the groovy warnings don't matter. * changelog updates from PR review. * Update agent/runtime-attach/build.gradle.kts Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * changelog updates to give new name. * ran ./gradlew :spotlessApply as per pipeline failure message Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
heyams
pushed a commit
that referenced
this pull request
Sep 16, 2022
…#2503) * Build changes needed to add an Automatic Module Name to Runtime Attach (#1) Build changes needed to add an Automatic Module Name so this library can be imported into modular java projects. * I'll build with 17 since that's what we're using for the modular app that needs this. * going back to 8 since the groovy warnings don't matter. * changelog updates from PR review. * Update agent/runtime-attach/build.gradle.kts Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * changelog updates to give new name. * ran ./gradlew :spotlessApply as per pipeline failure message Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
heyams
pushed a commit
that referenced
this pull request
Sep 16, 2022
…#2503) * Build changes needed to add an Automatic Module Name to Runtime Attach (#1) Build changes needed to add an Automatic Module Name so this library can be imported into modular java projects. * I'll build with 17 since that's what we're using for the modular app that needs this. * going back to 8 since the groovy warnings don't matter. * changelog updates from PR review. * Update agent/runtime-attach/build.gradle.kts Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * changelog updates to give new name. * ran ./gradlew :spotlessApply as per pipeline failure message Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
heyams
pushed a commit
that referenced
this pull request
Sep 16, 2022
…#2503) * Build changes needed to add an Automatic Module Name to Runtime Attach (#1) Build changes needed to add an Automatic Module Name so this library can be imported into modular java projects. * I'll build with 17 since that's what we're using for the modular app that needs this. * going back to 8 since the groovy warnings don't matter. * changelog updates from PR review. * Update agent/runtime-attach/build.gradle.kts Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * changelog updates to give new name. * ran ./gradlew :spotlessApply as per pipeline failure message Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.