Remove OpProcessingController, use LoaderContainerTracker in propertyDDS tests #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
markfields and
agarwal-navin
and removed request for
a team
github-actions
bot
added
area: dds: propertydds
area: tests
curtisman
reviewed
Oct 8, 2021
experimental/PropertyDDS/packages/property-dds/src/test/rebasing.spec.ts
Show resolved
Hide resolved
curtisman
reviewed
Oct 8, 2021
github-actions
bot
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight changes in reconnect logic (see #7753, #7393) result in failures in PropertyDDS UTs.
Looking a bit deeper, I can't easily follow intentions in OpProcessingController.
For example, OpProcessingController.process(dm1) will leave all but dm1 paused. UTs do rely on that (it's pretty clearly from some of them), in other places it feels like it's unintended result. And I do not think it correctly waits for all pending activity to be flushed (as observed in above mentioned PRs).
Given that it's deprecated and repo uses LoaderContainerTracker (explicitly or implicitly through), it's time to do the move.
Some random tests fail with this change, but are addressed by increasing timeout.
We saw this problem before with these tests - see pending #7350