Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for scripts 1 and 2 #2

Closed
wants to merge 2 commits into from
Closed

Updates for scripts 1 and 2 #2

wants to merge 2 commits into from

Conversation

mrbodean
Copy link
Member

@mrbodean mrbodean commented May 5, 2016

Added error checking and moved some functions from the script to a functions script to reduce some of the code duplication. Added -verbose option and appending to log files.
Accept or reject, I am just sharing.

Added functions.ps1
1_prereq.ps1 complete
2_createParentDisks.ps1 60% complete
@jaromirk
Copy link
Collaborator

jaromirk commented May 5, 2016

Really cool! Ill take a look more in depth as ill get to pc. Thx!

@jaromirk
Copy link
Collaborator

jaromirk commented May 5, 2016

I reviewed it, cool! Can you send more functions to functions.ps1? Also from 3_deploy? I'll test it next week and most probably merge it. This is really what I needed as I'm new to scripting..

@mrbodean
Copy link
Member Author

mrbodean commented May 5, 2016

Sure, Glad to help out. This really helps me rebuild my labs for experimentation.

@jaromirk
Copy link
Collaborator

jaromirk commented May 5, 2016

I plan change in deploy to support better win 2012 r2 clusters (specify multiple shared disks), so function would really help.

From: Jon aka @mrbodean [mailto:notifications@github.com]
Sent: Thursday, May 5, 2016 11:19 PM
To: Microsoft/ws2016lab ws2016lab@noreply.github.com
Cc: Jaromir Kaspar jaromirk@microsoft.com; Comment comment@noreply.github.com
Subject: Re: [Microsoft/ws2016lab] Updates for scripts 1 and 2 (#2)

Sure, Glad to help out. This really helps me rebuild my labs for experimentation.


You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-217283100

@MS-MatthewWalker
Copy link

you can review https://github.com/PlagueHO/LabBuilder for ideas on functions

@MS-MatthewWalker
Copy link

Also do you want to do more work or go ahead and commit the changes?

@jaromirk
Copy link
Collaborator

jaromirk commented May 7, 2016

Hey all, I tested it and it crashes when running scripts is disabled on system (defaults). Ill hold merge and will take a look deeper and with Matt we will work on merging the ideas (I like separate functions.ps1 but not sure as I like as few files as possible., I'd like to discuss write-output as it does not produce color output- I like solutions as simple as possible and there are just few duplicates (one answer file and elevation ... Can you take a look into how to rewrite creating vm in 3_deploy) thx!

@jaromirk
Copy link
Collaborator

Hi! I just ran thru the changes. I keep functions in the scripts and I kept write-host instead of write-output (or error/info) as this is interactive script and I want to show colored output. I grabbed some ideas. THX!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants