Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SupportClasses.cs #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

israelfink
Copy link

Print Handle type.
in case of a permanent handle, print also the RH name
@amarochk @RonaldAi, Please review my proposal.
Thanks,

Print Handle type. 
in case of  a permanent handle, print also the RH name
Copy link
Contributor

@amarochk amarochk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is good, but it cannot be implemented this way, as you are overriding the member name with the handle's value. What you need to do is to move your special case if after the // Recurse comment to replace the standard value processing with printing the hex value of the handle member followed by its RH name in parenthesis.

@israelfink
Copy link
Author

@amarochk, do you mean inside the ToStringInternal function?
The problem is that inside this function, the handle is represented as a uint, and we didn't have any idea that it is a TpmHandle.
Or do you mean to add it in a separated line?

@amarochk
Copy link
Contributor

Just move it lower in the same function (after the name and type info is printed) and do not recurse (i.e. print the handle value inside your if statement and return).

@RonaldAi
Copy link
Contributor

@israelfink Andrey had some feedback on your PR. Could you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants