Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Grunt section #2285

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Improve Grunt section #2285

merged 3 commits into from
Jul 24, 2023

Conversation

yelliver
Copy link
Contributor

Currently, in Grunt section, it recommended grunt-ts, but it is no longer maintained, using some out-date, vulnerable dependencies. I add a second approach which uses grunt-browserify combined with tsify

@ghost
Copy link

ghost commented Feb 27, 2022

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@yelliver yelliver closed this Feb 28, 2022
@yelliver yelliver reopened this Feb 28, 2022
@jakebailey
Copy link
Member

To me, I'm not sure it's still valuable to have this section; even the new projects you've linked to haven't been updated in years. The same goes for a few other projects on this page.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure this page really is of value anymore, but this change isn't wrong, so, LGTM I suppose.

@jakebailey jakebailey closed this Jul 24, 2023
@jakebailey jakebailey reopened this Jul 24, 2023
@jakebailey jakebailey enabled auto-merge (squash) July 24, 2023 21:07
@jakebailey jakebailey disabled auto-merge July 24, 2023 21:48
@jakebailey
Copy link
Member

Seems like github is acting up:

image

I'll click the button to bypass the rule.

@jakebailey jakebailey merged commit f9d0479 into microsoft:v2 Jul 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants