New introduction for Mapped Types article #2346
Conversation
The current introduction in the Mapped Types article is unclear (and what's the relevance of an _Only Fools and Horses_ reference?): the example given didn't really demonstrate what "mapping" one type to another meant by explicit example.
|
@orta sorry for pinging you, but as the main active contributor to TS's docs, do you know what's holding-up review and approval of my PR? |
|
Yeah, I looked at it but removing the only fools and horses reference kinda dinged your PR from my perspective, keeping any sense of whimsy and light heartedness in the docs is a battle that sometimes I'm just not in the mood to have. We get good PRs like this that are a net positive for the individual topic but slowly make the docs really dry when going through the whole handbook. Which makes giving feedback hard because I think it documents the syntax well, and this page is effectively the reference for the syntax even though it lives in the handbook. So I think I land on the side of losing that is a shame, it's probably worth it in this case. WRT it getting merged though, that's on someone with write access now I'm afraid and I think the team are still figuring out what they want there. |
There was a problem hiding this comment.
One thing I'm unsure of in this change is that the intro now effectively explains everything in one go, specifically the next "mapping modifiers" section. I'm not sure if that's good or bad, without getting others to look and see what might be good for first time readers.
|
FYI, we can't really consider taking this without the CLA stuff above; are you still interested in finishing this PR? |
|
@microsoft-github-policy-service agree @jakebailey I renamed my GitHub account within the past year, looks like the CLA-Bot isn't aware of renamed GitHub accounts - is it stuck? |
packages/documentation/copy/en/handbook-v2/Type Manipulation/Mapped Types.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/en/handbook-v2/Type Manipulation/Mapped Types.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/en/handbook-v2/Type Manipulation/Mapped Types.md
Outdated
Show resolved
Hide resolved
packages/documentation/copy/en/handbook-v2/Type Manipulation/Mapped Types.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
|
@jakebailey Sorry I forgot about this PR for almost a year. I've accepted your proposed changes as-is (for the sake of expediency) - there are some minor changes I'd have liked to have made or added now, but GitHub's online editor just wasn't working for me today - but anyway. |
The current introduction in the Mapped Types article is unclear (and what's the relevance of an Only Fools and Horses reference?): the example given didn't really demonstrate what "mapping" one type to another meant by explicit example.