Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verbatimModuleSyntax to Related #2896

Merged

Conversation

agilgur5
Copy link
Contributor

Summary

preserveValueImports and importsNotUsedAsValues should be Related to verbatimModuleSyntax

Details

  • preserveValueImports and importsNotUsedAsValues are now deprecated, and produce warnings as well

    • they are deprecated in favor of verbatimModuleSyntax and mention that in their descriptions, but not in their Related
  • do not link back from verbatimModuleSyntax as the old config options are deprecated

  • also add a new line between this group and listFiles as these are not related to each other

    • consistently have a new line between different related groups

- `preserveValueImports` and `importsNotUsedAsValues` are now deprecated, and produce warnings as well
  - they are deprecated in favor of `verbatimModuleSyntax` and mention that in their descriptions, but not in their Related

- do not link back from `verbatimModuleSyntax` as the old config options are deprecated

- also add a new line between this group and `listFiles` as these are not related to each other
  - consistently have a new line between different related groups
@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Jul 18, 2023
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2896.centralus.azurestaticapps.net

@agilgur5
Copy link
Contributor Author

agilgur5 commented Jul 18, 2023

Preview looks correct to me:

Screenshot 2023-07-18 at 2 52 28 PM

@jakebailey jakebailey merged commit 6510107 into microsoft:v2 Jul 18, 2023
5 of 6 checks passed
@agilgur5 agilgur5 deleted the feat-relatedto-verbatim-module-syntax branch July 18, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants