Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small design issue for "get started" card and "headline diagram" #3143

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

imhalid
Copy link
Contributor

@imhalid imhalid commented Jun 5, 2024

Hello,

I fixed a few minor issues I noticed on the homepage. Under the headline diagram, the .text class was missing the bottom parameter for the border-radius, which caused a bad appearance.

In the get started card design, changing the border value on hover caused alignment issues. Using outline instead of border solved the problem.

Headline Diagram Issue

Before After
Screenshot 2024-06-05 at 3 20 06 PM Screenshot 2024-06-05 at 3 20 21 PM

Get Started Card Issue

Before After
Kapture 2024-06-05 at 15 26 45 Kapture 2024-06-05 at 15 30 26

@imhalid
Copy link
Contributor Author

imhalid commented Jun 5, 2024

@microsoft-github-policy-service agree

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3143.centralus.5.azurestaticapps.net

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakebailey jakebailey merged commit 0594671 into microsoft:v2 Jun 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants