Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix "go to implementation" for node modules #39426

Closed
wants to merge 2 commits into from

Conversation

sheerun
Copy link

@sheerun sheerun commented Jul 5, 2020

Here are failing tests for issue #37777 The issue is with "go to implementation" and "go to definition" which doesn't work for node modules without .ts files (it points to type definition in d.ts file of @types instead)

I cannot figure out how to fix them in code. Maybe someone can help?

@ghost
Copy link

ghost commented Jul 5, 2020

CLA assistant check
All CLA requirements met.

@sb-bilal-dev
Copy link

Any updates on fixing failing tests?

@sheerun
Copy link
Author

sheerun commented Sep 6, 2020

@sb-bilal-dev As mentioned, I've left it for TypeScript team

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 6, 2020
@sheerun
Copy link
Author

sheerun commented Sep 6, 2020

btw. you can run failing test shown here by gulp runtests --tests="with type definitions of commonjs module"

@sandersn
Copy link
Member

Thanks for the tests @sheerun. Were you able to figure out how to make progress? Unfortunately, we can't give one-on-one help, but you can probably find some knowledgeable people at discord.gg/typescript.

If you're still stuck on this, I may close it to keep the number of open PRs down, and so that people won't be deterred from trying to fix this issue by seeing an open PR on it.

@sandersn sandersn self-assigned this Oct 27, 2020
@sheerun
Copy link
Author

sheerun commented Oct 27, 2020

OK then please close it

@sandersn sandersn closed this Oct 27, 2020
@fabOnReact
Copy link

@sandersn can we have this issue fixed? Please. It is important for opensource contributors to navigate to the implementation in node-modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants