-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix "go to implementation" for node modules #39426
Conversation
Any updates on fixing failing tests? |
@sb-bilal-dev As mentioned, I've left it for TypeScript team |
btw. you can run failing test shown here by |
Thanks for the tests @sheerun. Were you able to figure out how to make progress? Unfortunately, we can't give one-on-one help, but you can probably find some knowledgeable people at discord.gg/typescript. If you're still stuck on this, I may close it to keep the number of open PRs down, and so that people won't be deterred from trying to fix this issue by seeing an open PR on it. |
OK then please close it |
@sandersn can we have this issue fixed? Please. It is important for opensource contributors to navigate to the implementation in node-modules |
Here are failing tests for issue #37777 The issue is with "go to implementation" and "go to definition" which doesn't work for node modules without .ts files (it points to type definition in d.ts file of
@types
instead)I cannot figure out how to fix them in code. Maybe someone can help?