deduplicate references lists in tsbuildinfo #43079
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
referencedMap
orexportedModulesMap
contain duplicates, they are replaced with an index of the deduplicated value inreferencedMapLists
resp.exportedModulesMapLists
.This is actually quite common as .d.ts and .ts file often share references.
This saves a bit storage, makes restoring faster and due to using references to a shared list (since immutable) this also saves a bit of memory.
Finding duplicates during storing can be expensive, so we make use of the equal identity when this was restored from tsbuildinfo. Otherwise we create a Map by list length to avoid checking too many lists.
Backlog
milestone (required)master
branchgulp runtests
locally