Sanitize version string for syntactically invalid buildinfo baselines #59932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightlies haven't been publishing for a few days because some new baselines inadvertently captured the current ts version in them. The fancy automatic
.buildinfo
version stripping logic done by the builder baselines only applies to syntactically valid.buildinfo
files, so these tests with slightly invalid ones were inadvertently capturing the current version in the test baseline. Do note, with how the version removal machinery works, this extra ad-hoc sanitization is edit-order-dependent - if you try and make this edit before making the file syntactically invalid, the version-stripping-aware-sys will just add the current version right back to the file when it's re-read for the 2nd edit. 😅